Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bic-333_mee_support #166

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: bic-333_mee_support #166

wants to merge 7 commits into from

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Jan 13, 2025

PR-Codex overview

This PR primarily focuses on refactoring the codebase to improve consistency and readability, particularly around the handling of validatorAddress instead of k1ValidatorAddress. It also introduces new utility functions and modifies existing ones for better functionality.

Detailed summary

  • Removed getCounterFactualAddress utility.
  • Replaced all instances of k1ValidatorAddress with validatorAddress.
  • Updated sessionStorageData to include scraping data.
  • Added inProduction utility function.
  • Introduced new types and constants related to multichain operations.
  • Refactored test files to align with the new structure.
  • Updated workflow files for better CI/CD handling.
  • Enhanced error handling in various utility functions.

The following files were skipped due to too many changes: src/sdk/account/decorators/getNexusAddress.ts, src/sdk/clients/decorators/mee/signFusionQuote.test.ts, src/sdk/clients/decorators/mee/signFusionQuote.ts, src/sdk/clients/decorators/mee/waitForSupertransactionReceipt.ts, src/sdk/account/decorators/getUnifiedERC20Balance.ts, src/sdk/account/decorators/getFactoryData.ts, src/sdk/account/decorators/getFactoryData.test.ts, src/sdk/account/utils/toAcrossPlugin.ts, src/sdk/account/toNexusAccount.addresses.test.ts, src/sdk/account/toMultiChainNexusAccount.test.ts, src/sdk/constants/abi/AccountFactory.ts, src/sdk/account/toNexusAccount.ts, src/sdk/account/utils/getMultichainContract.ts, src/sdk/account/toMultiChainNexusAccount.ts, src/sdk/clients/decorators/mee/index.ts, src/sdk/clients/createMeeClient.test.ts, scripts/fetch:tokenMap.ts, src/sdk/account/decorators/buildBridgeInstructions.ts, src/sdk/clients/decorators/mee/getQuote.ts, src/sdk/constants/tokens/__AUTO_GENERATED__.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Jan 13, 2025

size-limit report 📦

Path Size
core (esm) 18.34 KB (+7.28% 🔺)
core (cjs) 24.93 KB (+5.92% 🔺)
bundler (tree-shaking) 518 B (0%)
paymaster (tree-shaking) 543 B (0%)

@joepegler joepegler marked this pull request as draft January 14, 2025 10:57
@joepegler joepegler force-pushed the feat/add_mee branch 2 times, most recently from 0dd7c8c to 743196e Compare January 14, 2025 17:26
@joepegler joepegler force-pushed the feat/add_mee branch 3 times, most recently from 6b89cac to 1d6ac35 Compare January 14, 2025 21:55
@joepegler joepegler marked this pull request as ready for review January 15, 2025 11:33
@joepegler joepegler changed the title feat/bic-333_mee_support feat: bic-333_mee_support Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant